search

llondon6 / nrutils_dev

Python API for low-level analysis of NR data: Psi4, strain, modeling, lal+pycbc interface when appropriate
MIT License
9 stars 4 forks source link

fix rename of romSpline to romspline 'S' -> 's' #25

Closed Cyberface closed 7 years ago

Cyberface commented 7 years ago

@llondon6 the romspline change you made is incompatible with bundlers.py. This fixes it.

Cyberface commented 7 years ago

:D

On a related note, I don't seem to be picking up the local version of romspline in the workflow folder. I had to manually add it to my path. Is that what you do?

Why can't romspline come with a bloody setup.py file :/

llondon6 commented 7 years ago

the old romspline version was just a file that could be imported locally, so it makes sense that you have to add the new folder to your path

On Mon, Feb 13, 2017 at 8:49 PM, Sebastian Khan notifications@github.com wrote:

:D

On a related note, I don't seem to be picking up the local version of romspline in the workflow folder. I had to manually add it to my path. Is that what you do?

Why can't romspline come with a bloody setup.py file :/

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/llondon6/nrutils_dev/pull/25#issuecomment-279517588, or mute the thread https://github.com/notifications/unsubscribe-auth/AHpNtZi_xEdNnf9-puaUbSAWsP8JEcOqks5rcMHXgaJpZM4L_lqD .