search

llondon6 / nrutils_dev

Python API for low-level analysis of NR data: Psi4, strain, modeling, lal+pycbc interface when appropriate
MIT License
9 stars 4 forks source link

I think lvcnr5_to_gwylm needs to have M_RELATIVE_SIGN_CONVENTION implemented #34

Closed Cyberface closed 5 years ago

Cyberface commented 6 years ago

The function to load lvcnr into nrutils seems to be lacking the M_RELATIVE_SIGN_CONVENTION check

https://github.com/llondon6/nrutils_dev/blob/master/nrutils/core/nrsc.py#L4105

llondon6 commented 6 years ago

thanks; agreed -- btw (not sure if this was in one my of examples), you will need to set the clean=True keyword when looking at the related Fourier transforms; related: Ed used a hybrid for the paper plots, which seems to explain part of the difference in my recent figure 2 mock

On Wed, Feb 21, 2018 at 11:34 AM, Sebastian Khan notifications@github.com wrote:

https://github.com/llondon6/nrutils_dev/blob/master/ nrutils/core/nrsc.py#L4105

M_RELATIVE_SIGN_CONVENTION

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/llondon6/nrutils_dev/issues/34, or mute the thread https://github.com/notifications/unsubscribe-auth/AHpNtQIfKr18AwHX2pgUjv8jTKU_JESLks5tW_9agaJpZM4SNfEK .

--

L. London

Research Associate, Gravitational Waves

School of Physics and Astronomy

Cardiff University

Cyberface commented 6 years ago

yeah I was playing around with clean=False/True

Good to know about the paper plots

Cyberface commented 6 years ago

Trying to fix this with this PR https://github.com/llondon6/nrutils_dev/pull/36