search

llooker / google_ga360

Looker Blocks for Google Analytics 360
MIT License
39 stars 51 forks source link

Incorrect type for visitStartSeconds #1

Closed sandhub closed 6 years ago

sandhub commented 7 years ago

In the Google Analytics block, the type for visitStartSeconds is specified as date whereas it should be number. This is causing the function TIMESTAMP_MILLIS to throw an error when used.

Can we please fix this?

PS: It would be good to provide the community here an option to open PR's so that we can fix any pieces that may be broken. 😄

DillonMorrison commented 6 years ago

Thanks! this has been added. We're working on a better way to submit PRs for each Block right now - we're hoping to introduce it in '18.