llooker / google_ga360

Looker Blocks for Google Analytics 360
MIT License
39 stars 51 forks source link

Support timezone picker on ga_session.visitStart #26

Open henrymei opened 4 years ago

henrymei commented 4 years ago

Currently (in at least BigQuery), using TIMESTAMP(${visitStartSeconds}) will trigger a double cast when you pick a non-UTC timezone since visitStart treats the datetime it receives from visitStartSeconds as a string. Adding an inline type-hint avoids this and gives the desired behavior.

This is also pointed out in the LookML documentation (thanks Olivia from DCL for finding it!).

cc: @ernestoongaro (since you seem to be the most active maintainer 😅)