lloyd / ircloggr

A system for producing web accessible IRC logs, in node.js.
http://irclog.gr
ISC License
34 stars 10 forks source link

String interpolation in database has high bogosity quotient #34

Open jwise opened 10 years ago

jwise commented 10 years ago

Currently, ircloggr interpolates strings into the database -- with mild massaging -- to create a table for each channel. This is pretty bogus. Some day, someone will extend ircloggr to have user-configurable channels that it lurks on, and will get owned six ways to Sunday.

This needs to be documented, or preferably, fixed. (The fix is to keep everything in one table with an added column for 'channelid', and have another table with a {channelid, server, channel}.)

33 is a workaround for one particular failure mode that bit me this evening, but there are many more...