lloyd / node-toobusy

Build Node.JS servers that don't fall over.
1.3k stars 128 forks source link

Compile for io.js 1.0.4 #40

Open alexfernandez opened 9 years ago

alexfernandez commented 9 years ago

When compiling for io.js latest (1.0.4), node-gyp complains:

In file included from ../toobusy.cc:3:0:
/home/ubuntu/.node-gyp/1.0.4/deps/uv/include/uv.h:756:15: error:   initializing argument 2 of ‘int uv_timer_start(uv_timer_t*, uv_timer_cb, uint64_t, uint64_t)’ [-fpermissive]
 UV_EXTERN int uv_timer_start(uv_timer_t* handle,
               ^
../toobusy.cc: In function ‘v8::Handle<v8::Value> TooBusy(const int&)’:
../toobusy.cc:38:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
../toobusy.cc: In function ‘v8::Handle<v8::Value> ShutDown(const int&)’:
../toobusy.cc:46:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
../toobusy.cc: In function ‘v8::Handle<v8::Value> Lag(const int&)’:
../toobusy.cc:51:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
../toobusy.cc: In function ‘v8::Handle<v8::Value> HighWaterMark(const int&)’:
../toobusy.cc:72:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
make: *** [Release/obj.target/toobusy/toobusy.o] Error 1
make: Leaving directory `/home/ubuntu/adserver/node_modules/toobusy/build'

And a few other errors. Probably related to issue #38, although the errors seem to be different.

matejkramny commented 9 years ago

io.js uses different version of V8, so its possible that their C++ API has changed.

There are JS-only forks of this project, which will work on io.js.

Thanks,

Matej Kramny

On Monday, 26 January 2015 at 2:29 pm, Alex Fernández wrote:

When compiling for io.js latest (1.0.4), node-gyp complains: In file included from ../toobusy.cc:3 (http://toobusy.cc:3):0: /home/ubuntu/.node-gyp/1.0.4/deps/uv/include/uv.h:756:15: error: initializing argument 2 of ‘int uv_timer_start(uv_timert, uv_timer_cb, uint64_t, uint64_t)’ [-fpermissive] UV_EXTERN int uv_timer_start(uv_timert handle, ^ ../toobusy.cc (http://toobusy.cc): In function ‘v8::Handlev8::Value TooBusy(const int&)’: ../toobusy.cc:38 (http://toobusy.cc:38):1: warning: control reaches end of non-void function [-Wreturn-type] } ^ ../toobusy.cc (http://toobusy.cc): In function ‘v8::Handlev8::Value ShutDown(const int&)’: ../toobusy.cc:46 (http://toobusy.cc:46):1: warning: control reaches end of non-void function [-Wreturn-type] } ^ ../toobusy.cc (http://toobusy.cc): In function ‘v8::Handlev8::Value Lag(const int&)’: ../toobusy.cc:51 (http://toobusy.cc:51):1: warning: control reaches end of non-void function [-Wreturn-type] } ^ ../toobusy.cc (http://toobusy.cc): In function ‘v8::Handlev8::Value HighWaterMark(const int&)’: ../toobusy.cc:72 (http://toobusy.cc:72):1: warning: control reaches end of non-void function [-Wreturn-type] } ^ make: *\ [Release/obj.target/toobusy/toobusy.o] Error 1 make: Leaving directory `/home/ubuntu/adserver/node_modules/toobusy/build'
And a few other errors. Probably related to issue #38 (https://github.com/lloyd/node-toobusy/issues/38), although the errors seem to be different.

— Reply to this email directly or view it on GitHub (https://github.com/lloyd/node-toobusy/issues/40).

alexfernandez commented 9 years ago

Thanks a lot. Any particular forks that you would recommend?

matejkramny commented 9 years ago

This seems to be the most up-to-date: https://github.com/STRML/node-toobusy

Also see https://github.com/lloyd/node-toobusy/issues/33 as you might have a similar problem i had.