search

lloyd / yajl

A fast streaming JSON parsing library in C.
http://lloyd.github.com/yajl
ISC License
2.15k stars 435 forks source link

Remove MSVC and other compiler specific code. #213

Open fandjelo opened 5 years ago

fandjelo commented 5 years ago

You should try not to use compiler specific code in the cmake scripts, because if not implemented carefully it can hurt cross compilation using other compilers, in this case for example mingw instead of msvc. All compiler specific settings should be implemented in cmake toolchain files, everything else bloats your build scripts in a best case. In a worst case it ruins your build procedure completely.