lloyd / yajl

A fast streaming JSON parsing library in C.
http://lloyd.github.com/yajl
ISC License
2.15k stars 435 forks source link

CVE-2017-16516 #248

Open pfsmorigo opened 1 year ago

pfsmorigo commented 1 year ago

Hello, yajl-ruby has a fix for CVE-2017-16516 that might be affecting yajl as well. Can you backport it? The commit is https://github.com/brianmario/yajl-ruby/commit/a8ca8f476655adaa187eedc60bdc770fff3c51ce

Thanks!

berrange commented 1 year ago

I confirmed the problem affects git master, but only if asserts are enabled. IOW,

Simply not passing CMAKE_BUILD_TYPE at all appears to have the same behaviour as the Release build on my cmake install at least.

The fix mentioned from yajl-ruby works on git master to avoid the asserts.