lloydmeta / enumeratum

A type-safe, reflection-free, powerful enumeration implementation for Scala with exhaustive pattern match warnings and helpful integrations.
MIT License
1.18k stars 146 forks source link

KenEncoder and KeyDecoder for CirceEnum #221

Closed poslegm closed 5 years ago

poslegm commented 5 years ago

CirceEnum generates only Decoder and Encoder for circe. Is there availability to generate also KeyEncoder and KeyDecoder?

lloydmeta commented 5 years ago

Definitely, please feel free to contribute :)

poslegm commented 5 years ago

@lloydmeta I just found this PR #219. What restrictions do not allow it to be merged? I can help to resolve it.

FYI @yaroot

lloydmeta commented 5 years ago

I’m not exactly sure if it was done! The last part of the description seems to imply more was to come. @yaroot

yaroot commented 5 years ago

there's nothing left, could be merged now.

lloydmeta commented 5 years ago

Thanks @yaroot and @poslegm I just merged #219 and pushed a new release of enumeratum-circe 1.5.21.

poslegm commented 5 years ago

Awesome, thank you very much!