search

lloydmeta / enumeratum

A type-safe, reflection-free, powerful enumeration implementation for Scala with exhaustive pattern match warnings and helpful integrations.
MIT License
1.19k stars 148 forks source link

Upgrade to 3.3.0 #367

Closed jatcwang closed 1 year ago

limansky commented 1 year ago

You should change .github/workflows/ci.yml as well, to have same version in CI build.

codecov-commenter commented 1 year ago

Codecov Report

Merging #367 (d092bf1) into master (f9b528a) will not change coverage. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #367   +/-   ##
=======================================
  Coverage   85.87%   85.87%           
=======================================
  Files          65       65           
  Lines         531      531           
  Branches       24       24           
=======================================
  Hits          456      456           
  Misses         75       75
limansky commented 1 year ago

@lloydmeta Is it really needed to support Scala 2.11.x in 2023? It looks like Scala Native doesn't support 2.11 since 0.4.10 (Jan 2023).

lloydmeta commented 1 year ago

@lloydmeta Is it really needed to support Scala 2.11.x in 2023? It looks like Scala Native doesn't support 2.11 since 0.4.10 (Jan 2023).

I have no qualms about removing support for 2.11 (can't believe the last release was 2017-11-09 🥲 )

limansky commented 1 year ago

@lloydmeta I've made PR #369

lloydmeta commented 1 year ago

Closing this because it was handled via https://github.com/lloydmeta/enumeratum/pull/370