search

lloydmeta / enumeratum

A type-safe, reflection-free, powerful enumeration implementation for Scala with exhaustive pattern match warnings and helpful integrations.
MIT License
1.18k stars 146 forks source link

Bump play-json #379

Closed markarasev closed 8 months ago

codecov-commenter commented 8 months ago

Codecov Report

Merging #379 (c1616ad) into master (1702c6b) will not change coverage. The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master     #379   +/-   ##
=======================================
  Coverage   85.52%   85.52%           
=======================================
  Files          65       65           
  Lines         518      518           
  Branches       31       31           
=======================================
  Hits          443      443           
  Misses         75       75
gaeljw commented 8 months ago

Shouldn't we bump to org.playframework:play-json:3.0.0 directly?

The artifact groupId is renamed but the content is the same (https://github.com/playframework/play-json/compare/2.10.1...3.0.0).

lloydmeta commented 8 months ago

Shouldn't we bump to org.playframework:play-json:3.0.0 directly?

The artifact groupId is renamed but the content is the same (playframework/play-json@2.10.1...3.0.0).

That could be bigger + separate PR that would be very welcome indeed.

gaeljw commented 8 months ago

I'll provide the PR today then :)