lloydmeta / frunk

Funktional generic type-level programming in Rust: HList, Coproduct, Generic, LabelledGeneric, Validated, Monoid and friends.
https://beachape.com/frunk/
MIT License
1.25k stars 56 forks source link

Debug impls should use DebugStruct #153

Closed ExpHP closed 5 years ago

ExpHP commented 5 years ago

Just best practices; Debug impls should use the helpers on fmt::Formatter when possible in order to properly support {:#?}.

lloydmeta commented 5 years ago

I think after the conflicts in this one are fixed + merged, with #148 and #152, we have (more than) enough for a new minor-version-bumped release.

ExpHP commented 5 years ago

The next release has to be a major version bump because of the change to features in the no_std PR. For instance, somebody could be using Validated with default_features = false.

For that reason, I also want to close at least #138 which seems easy enough.

lloydmeta commented 5 years ago

The next release has to be a major version bump because of the change to features in the no_std PR. For instance, somebody could be using Validated with default_features = false.

For that reason, I also want to close at least #138 which seems easy enough.

🤦‍♂️ yes of course you're right; it needs to be a major bump.

lloydmeta commented 5 years ago

Hmm, actually no, I think since we are in x.y.z where x < 1 world, we are ok with just bumping the minor, even with a breaking change, and leaving a note

Staying with a minor version bump seems more preferable to me than force-introducing a 1.x.x which has major implications.

ExpHP commented 5 years ago

To be clear, 0.3.0 is what I meant by a major version bump. (I meant a bump of the first nonzero part of the version number, to indicate semver incompatibility)