Drop proc-macro-hack, upgrade syn to 2

lloydmeta / frunk

Funktional generic type-level programming in Rust: HList, Coproduct, Generic, LabelledGeneric, Validated, Monoid and friends.

https://beachape.com/frunk/

MIT License

1.24k stars 56 forks source link

Drop proc-macro-hack, upgrade syn to 2 #213

Closed CobaltCause closed 1 year ago

CobaltCause commented 1 year ago

proc-macro-hack is deprecated since it's not needed in newer versions of Rust
- See the note at the top of its docs.rs page
- If frunk does want to support the versions proc-macro-hack is needed for, this can be ignored
syn 2 has been released
- Upgrading would be nice so that users can compile less versions of syn

If the maintainers are interested in either or both of these changes, I can try to PR it, just thought I'd ask to gauge interest first.

ExpHP commented 1 year ago

Frunk is already using 2021 edition which was added in rust 1.56, so the MSRV (which I don't think we've invested much effort into tracking for frunk) is already beyond the versions that need proc-macro-hack (1.45) or syn 1 (1.50).

I would support both changes. proc-macro-hack in particular was considered a dinosaur even back during the time of my last major rust project. (syn 2 is news to me but I'm for it all the same)

CobaltCause commented 1 year ago

Frunk is already using 2021 edition

Oh lol. PR opened: #214.