search

lloydmeta / frunk

Funktional generic type-level programming in Rust: HList, Coproduct, Generic, LabelledGeneric, Validated, Monoid and friends.
https://beachape.com/frunk/
MIT License
1.29k stars 58 forks source link

avoid clippy::unneeded_field_pattern #216

Closed figsoda closed 1 year ago

figsoda commented 1 year ago

see https://github.com/rust-lang/rust-clippy/issues/11008

figsoda commented 1 year ago

I added a test, but I don't think it would run in CI, but I did find a bug from the test which I now have fixed

lloydmeta commented 1 year ago

I added a test .. but I did find a bug from the test which I now have fixed

Thanks ! Great that the test caught the bug!

but I don't think it would run in CI

Why do you think so?

https://github.com/lloydmeta/frunk/actions/runs/5352333868/jobs/9707151131?pr=216#step:5:185 seems to indicate your new test is running.

figsoda commented 1 year ago

Why do you think so?

The error only shows up when I run cargo clippy --tests --all, but it seems like --tests is not passed to cargo clippy in CI

lloydmeta commented 1 year ago

Ah in that case I think you need to update this bit

https://github.com/lloydmeta/frunk/blob/df2d6ea6242c853ea16fca944b2b1ef2af939fdf/.github/workflows/ci.yml#L23-L27