search

lloydtorres / stately

A NationStates app for Android.
https://play.google.com/store/apps/details?id=com.lloydtorres.stately
Apache License 2.0
30 stars 8 forks source link

Removed Crashlytics and references to maven.io #18

Closed samtinel closed 3 years ago

samtinel commented 3 years ago

This PR removes Crashlytics and reference to maven.io. This means it is buildable by F-Droid. To be included, metadata has to be added, see #17 .

lloydtorres commented 3 years ago

Thanks so much for digging into this!

Per the commit that implemented Crashlytics, you'll also need to remove the app/fabric.properties file and the io.fabric.ApiKey metadata tag from the manifest. Would you mind updating your pull request with those changes?

Also, would you like to be added to the contributors list? If so, what name would you prefer for that? I'll make a separate commit to add you in once the pull request is merged in.

samtinel commented 3 years ago

updated the PR with the new changes, but please do not merge yet, tomorrow I will test more thoroughly

Also, would you like to be added to the contributors list?

yes, thanks! use "Samtinel" please

samtinel commented 3 years ago

It currently doesn't build for me, looks like gradle. will report back. Could not initialize class org.codehaus.groovy.runtime.InvokerHelper

samtinel commented 3 years ago

Ah, interesting. Apparently Gradle has to be >= 6.3 to work with JDK 14. Downgrading java fixed that. Building works.

samtinel commented 3 years ago

It runs also fine through the smoke test. What I wonder is if in the settings the switch "send crash reports" also needs removal. A first look didn't really tell me what SETTING_CRASHREPORT does. Will dig into it in the following days.

lloydtorres commented 3 years ago

Good catch, definitely get rid of that switch while you're at it.

samtinel commented 3 years ago

Removed the toggle and its resources, as well as the mention of CrashLytics in the readme. It compiles and passes the smoke test. So in my eyes this is ready to merge, and then the last hurdle is #17. After that maybe a minor version bump?

lloydtorres commented 3 years ago

This pull request LGTM, thanks so much for doing this!

We can handle blocking changes related to F-Droid in #17.