search

lloydtorres / stately

A NationStates app for Android.
https://play.google.com/store/apps/details?id=com.lloydtorres.stately
Apache License 2.0
30 stars 8 forks source link

[fdroid] inform user of tracking #24

Open samtinel opened 3 years ago

samtinel commented 3 years ago

Reworked the message to take out the "adversariel" nature of it. Please don't instantly close the issue if you still have concerns, let's try to create a solution which one the one hand empowers the user to make an informed choice, and on the other fits your vision for the project.

lloydtorres commented 3 years ago

Slightly better, but still not quite user friendly. A non-technical user would have no idea what a WebView is. Please take a look at some of the other dialogs within the app for string examples.

It would also be better if the disclaimer on Google Analytics is shown in a smaller, more subtle font style. Take a look at the "Send Telegram" option under Settings for an example.

As with any UI change, please take a screenshot of the proposed UI changes and attach it to the pull request.

samtinel commented 3 years ago

I have simplified it as much as I can, it's now mostly the same as before. As per my own research, I can't really change the font (size) in the pop-up, without a substantial amount of code (pollution). In my opinion this is a good compromise between simplicity and necessary information. Screenshot: image As this is a native dialog, it obviously varies based on the version of Android.

IzzySoft commented 2 years ago

@lloydtorres will this be merged anytime soon? Your app is still pending its listing on F-Droid, just waiting for this one. That merge request would now enter pre-closure state for missing feedback. Would be a real pity, as apart from this the entire review passed. Maybe you could merge this for now, and apply the polish later?