lltcggie / waifu2x-caffe

waifu2xのCaffe版
MIT License
8.04k stars 839 forks source link

Suggestion: Make CUI Unicode-aware #87

Closed alemonmk closed 7 years ago

alemonmk commented 7 years ago

What I want is very similar to what #67 requests. Current behavior is very unfriendly for building automation tools with it. The output field of GUI can be overridden to act like -o of CUI, why not -o of GUI? I can just use the CUI to achieve this, but it is not Unicode-aware, it does not correctly process anything not named in system locale.

I know not much in C++ but I tried to make the CUI Unicode-aware, just

but:

This is very frustrating and I don't bother trying again. I may:

I'm away from coding the next few days so take your time.

alemonmk commented 7 years ago

EDIT: I managed to get the libs and project to compile with a fresh VM & VS 2015. CUI went through and tested, it works fine. But GUI was stuck with a C2280 in MainDialog.cpp, Line 842. I'm not gonna touch that.

Anyways, here is the commit. https://github.com/alemonmk/waifu2x-caffe/commit/ba4a975ef11937f439287117840a6c085c03ac99 And here is the CUI executable: https://github.com/alemonmk/waifu2x-caffe/releases/download/git-c7d0206%2Bunicode/waifu2x-caffe-cui.exe

lltcggie commented 7 years ago

CUIでUNICODEでのビルドにも対応しました。 aaa43282701cf41067e3d1020cca35aa2ba88d0b

alemonmk commented 7 years ago

Thank you for saving me much headache. :)