llucasspot / boomboom

61 stars 18 forks source link

Working Track Selection #12

Closed GN13008 closed 9 months ago

GN13008 commented 9 months ago

Create Profil - select some track

Description

This PR working better with PR from back. You can now select song during profil selection.

Todo

Save selection during the next step

llucasspot commented 9 months ago

Hi, To follow up on my comment above I will not approve this PR. I think the best way to develop the app is to firstly develop the frontend with just the info that it needs with api mocks.

At the same time, we will develop backend and the needed endpoints. And at the end we will just need to update api type and endpoint url when backend will be ready. What do you think @Doelia ?

GN13008 commented 9 months ago

Did you see my PR on backend ?

I like to dev with real data this is why I work on back end front simultaneously. I will improve my code like Angel suggest waiting to your decision ...

llucasspot commented 9 months ago

Hi, Sorry I did not see your PR on backend. I understand now the changes that you have made. It is merger ;)

Be carefull when you change a class Interface like SpotifyApiServiceI to change also the mock class like SpotifyApiMockService to prevent bugs if others dev work with the MOCK_MODE. see : https://github.com/llucasspot/boomboom-front-react-native/pull/12/commits/7568f01c0604a80bdbe0f360901461e08b3cd920

Otherwise good job ;)