DCPU16: Update the test to the fact that byte is 16-bit, so sizeof(char)=1, sizeof(int)=1, sizeof(long)=2.

llvm-dcpu16 / clang

Clang frontend that supports DCPU16

Other

22 stars 6 forks source link

DCPU16: Update the test to the fact that byte is 16-bit, so sizeof(char)=1, sizeof(int)=1, sizeof(long)=2. #6

Closed krasin closed 12 years ago

krasin commented 12 years ago

Checked with make clang-test -j8.

Please, take a look at this CL. I think that it's correct that sizeof(int) == 1, if byte is 16-bit, but I am very unsure.

ghost commented 12 years ago

Indeed, byte/char/short/int should all be sizeof() = 1. This is the desired behavior, since later, the malloc implementation will take word based sizes.

Blei commented 12 years ago

LGTM. The changes I'm working on also change the "ByteSizes" in LLVM to use bytes of width 16, so that should be ok.

krasin commented 12 years ago

Thanks for the review. :)