search

llvm-mos / llvm-mos-sdk

SDK for developing with the llvm-mos compiler
https://www.llvm-mos.org
Other
266 stars 53 forks source link

Split neslib and nesdoug components so they are linked conditionally #217

Closed cogwheel closed 11 months ago

cogwheel commented 11 months ago

Fixes #214

mysterymath commented 11 months ago

Addresses #214

Nitpick, if you say the "Fixes" instead of "Addresses", Github will automatically close the issue on merge; very nice to have. See https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword for details.

EDIT: That list is quite long, you just happened to choose a word that isn't on it. I blame the list, get the thesaurus!

cogwheel commented 11 months ago

EDIT: That list is quite long, you just happened to choose a word that isn't on it. I blame the list, get the thesaurus!

This is very on-brand for me. ><

mysterymath commented 11 months ago

Unfortunately, I ended up having to revert this; see the above commit message for details.