Improve allocation of VRAM/PAL/OAM buffers

llvm-mos / llvm-mos-sdk

SDK for developing with the llvm-mos compiler

https://www.llvm-mos.org

Other

266 stars 53 forks source link

Improve allocation of VRAM/PAL/OAM buffers #222

Closed cogwheel closed 11 months ago

cogwheel commented 11 months ago

Fixes #215:

Use weak symbols
Move PAL_BUF out of hardware stack

cogwheel commented 11 months ago

Hmm this works with 26_Full_Game but not 21_Sprite_Zero.

cogwheel commented 11 months ago

Regarding https://github.com/llvm-mos/llvm-mos-sdk/pull/222/commits/b5d3522079bd51c39fda0a3b0b3c1a6358ff7a41 I'm curious about the reasoning for __post_vram_update. Is there ever a time the buffer shouldn't be cleared and the counter reset after writing it to vram?

mysterymath commented 11 months ago

Regarding b5d3522 I'm curious about the reasoning for __post_vram_update. Is there ever a time the buffer shouldn't be cleared and the counter reset after writing it to vram?

IIRC it was just that VRAM_BUF is a nesdoug addition to neslib, and it shouldn't trigger unless nesdoug is used.