[FIRRTL] Create global constants for annotation class name strings

llvm / circt

Circuit IR Compilers and Tools

https://circt.org

Other

1.67k stars 298 forks source link

[FIRRTL] Create global constants for annotation class name strings #2606

Closed prithayan closed 1 year ago

prithayan commented 2 years ago

Promote annotation strings used in various passes to some global constant, for example, lib/Dialect/FIRRTL/Transforms/BlackBoxReader.cpp :: StringRef verifBBClass = "freechips.rocketchip.annotations.InternalVerifBlackBoxAnnotation";

dtzSiFive commented 1 year ago

These generally seem to all be in AnnotationDetails.h these days, closing!

dtzSiFive commented 1 year ago

Found a stray instance, fixed! :smile: