llvm / circt

Circuit IR Compilers and Tools
https://circt.org
Other
1.67k stars 298 forks source link

[FIRRTL] Lower types test fail on nightly integration clang/debug #4577

Closed teqdruid closed 1 year ago

teqdruid commented 1 year ago

https://github.com/llvm/circt/actions/runs/3986148131/jobs/6834373298

-- Testing: 465 tests, 2 workers --
Testing:  0.. 10.. 20.. 30.. 40.. 50
FAIL: CIRCT :: Dialect/FIRRTL/lower-types.mlir (244 of 465)
******************** TEST 'CIRCT :: Dialect/FIRRTL/lower-types.mlir' FAILED ********************
Script:
--
: 'RUN: at line 1';   /__w/circt/circt/build/bin/circt-opt -pass-pipeline='builtin.module(firrtl.circuit(firrtl-lower-types))' /__w/circt/circt/test/Dialect/FIRRTL/lower-types.mlir | /__w/circt/circt/build/bin/FileCheck --check-prefixes=CHECK,COMMON /__w/circt/circt/test/Dialect/FIRRTL/lower-types.mlir
: 'RUN: at line 2';   /__w/circt/circt/build/bin/circt-opt -pass-pipeline='builtin.module(firrtl.circuit(firrtl-lower-types{preserve-aggregate=all}))' /__w/circt/circt/test/Dialect/FIRRTL/lower-types.mlir | /__w/circt/circt/build/bin/FileCheck --check-prefixes=AGGREGATE,COMMON /__w/circt/circt/test/Dialect/FIRRTL/lower-types.mlir
--
Exit Code: 2

Command Output (stderr):
--
/__w/circt/circt/test/Dialect/FIRRTL/lower-types.mlir:478:14: error: 'firrtl.instance' op has a wrong number of results; expected 1 but got 2
    %bar_a = firrtl.instance bar {annotations = [{a = "a"}]} @Bar(out a: !firrtl.vector<uint<1>, 2>)
             ^
/__w/circt/circt/test/Dialect/FIRRTL/lower-types.mlir:478:14: note: see current operation: %0:2 = "firrtl.instance"() {annotations = [{a = "a"}], moduleName = @Bar, name = "bar", nameKind = #firrtl<name_kind droppable_name>, portAnnotations = [[], []], portDirections = -1 : i2, portNames = ["a_0", "a_1"]} : () -> (!firrtl.uint<1>, !firrtl.uint<1>)
/__w/circt/circt/test/Dialect/FIRRTL/lower-types.mlir:473:3: note: original module declared here
  firrtl.module private @Bar(out %a: !firrtl.vector<uint<1>, 2>) {
  ^
FileCheck error: '<stdin>' is empty.
FileCheck command line:  /__w/circt/circt/build/bin/FileCheck --check-prefixes=AGGREGATE,COMMON /__w/circt/circt/test/Dialect/FIRRTL/lower-types.mlir

--

********************
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
********************
Failed Tests (1):
  CIRCT :: Dialect/FIRRTL/lower-types.mlir

Testing Time: 43.92s
  Passed           : 488
  Expectedly Failed:   4
  Failed           :   1
FAILED: tools/circt/test/CMakeFiles/check-circt /__w/circt/circt/build/tools/circt/test/CMakeFiles/check-circt 
cd /__w/circt/circt/build/tools/circt/test && /usr/bin/python3.9 /__w/circt/circt/build/./bin/llvm-lit -sv --show-unsupported /__w/circt/circt/build/tools/circt/test
ninja: build stopped: subcommand failed.
teqdruid commented 1 year ago

Re-running to determine this failure's determinism. https://github.com/llvm/circt/actions/runs/3986148131/jobs/6842545530

teqdruid commented 1 year ago

re-run passed so this is a Heisenbug.

uenoku commented 1 year ago

Thanks! https://github.com/llvm/circt/pull/4582 should fix the bug.