search

llvm / circt

Circuit IR Compilers and Tools
https://circt.org
Other
1.62k stars 281 forks source link

[CI] Don't run clang-tidy on non-gcc, maybe only use same clang-tidy as clang used #5957

Open dtzSiFive opened 1 year ago

dtzSiFive commented 1 year ago

Otherwise the flags used for clang-tidy are those chosen for GCC, such as this:

error: unknown argument: '-fno-lifetime-dse' [clang-diagnostic-error]

(Also, if clang-tidy fails, shouldn't the build fail?)

Thought this was fixed previously but can't find the change, so maybe it wasn't. Related: #5239 .

Observed here: https://github.com/llvm/circt/actions/runs/5978579297/job/16220967455?pr=5956#step:13:20

dtzSiFive commented 1 year ago

(title prescribes a solution, perhaps it shouldn't-- just let's fix this somehow :+1: )