llvm / circt

Circuit IR Compilers and Tools
https://circt.org
Other
1.64k stars 286 forks source link

[ESI] ESI runtime relies on CIRCT-defined CMake variables #7254

Closed mortbopet closed 3 months ago

mortbopet commented 3 months ago

E.g. https://github.com/llvm/circt/blob/20e08c092c67adf20d6b4114d06e45d5d8dc4965/lib/Dialect/ESI/runtime/cosim/CMakeLists.txt#L21-L24

relies on CIRCT_TOOLS_DIR. When ESI Runtime is built out-of-tree, CIRCT_TOOLS_DIR is undefined, resulting in an attempted copy of esi-cosim.py to /esi-cosim.py, which is illegal.

Some possible offending locations:

teqdruid commented 3 months ago

Huh. I could've sworn that I built this out of tree at some point. I'll fix on top of #7241 .