search

llvm / clangir

A new (MLIR based) high-level IR for clang.
https://clangir.org
Other
327 stars 86 forks source link

Can I try to make a lowering operation for cir.cos? #563

Closed zhoujingya closed 3 months ago

zhoujingya commented 3 months ago

Hello, I am newer for cir, and now I find many cir operations which are desired to be lowered to mlir are still not implemented yet, my first intention was lowering cir.cos to math.cos, but I am not sure it is ok or not

Lancern commented 3 months ago

my first intention was lowering cir.cos to math.cos, but I am not sure it is ok or not

That looks reasonable. You can always draft a PR and the community can give more solid feedbacks.