[CIR][CIRGen] Enable address space flags and re-categorize / fix usages

llvm / clangir

A new (MLIR based) high-level IR for clang.

https://clangir.org

Other

312 stars 86 forks source link

[CIR][CIRGen] Enable address space flags and re-categorize / fix usages #614

Closed seven-mile closed 1 month ago

seven-mile commented 1 month ago

Depend on #606 , will rebase after its merging.

This PR fixes simple cases and re-categorize other cases to addressSpaceInGlobalVar or addressSpaceCasting. Maybe the changes are hard to review😂. But I will solve them in months, so no need to be strict with the precise categorization.

seven-mile commented 1 month ago

Many thanks for reviewing this mess😂! I also found a bunch of extra usages to mark. I shall go through entirely.

For the test cases, I would better split this PR into two parts, one for NFC flags, another for fix with tests, making it tidier.