search

llvm / clangir

A new (MLIR based) high-level IR for clang.
https://clangir.org
Other
307 stars 84 forks source link

Revisit insertion point being restored by an InsertionGuard in `buildSwitchBody()` #665

Open bcardosolopes opened 3 weeks ago

bcardosolopes commented 3 weeks ago 
          These tests are failing because the insertion point is restored by an InsertionGuard in `buildSwitchBody()`. I suggest revising that part after #528 is merged to avoid conflict.

https://github.com/llvm/clangir/blob/3da10fafac66ff125fb59c602e41ad4b4f5cb382/clang/lib/CIR/CodeGen/CIRGenStmt.cpp#L972-L978

_Originally posted by @piggynl in https://github.com/llvm/clangir/pull/611#discussion_r1603235462_

bcardosolopes commented 3 weeks ago

@piggynl somehow I cannot assign this issue to you, but here's an issue to track this.