search

llvm / clangir

A new (MLIR based) high-level IR for clang.
https://clangir.org
Other
307 stars 84 forks source link

Replace uses of `isa`/`dyn_cast`/`cast`/... member functions #702

Closed jopperm closed 1 week ago

jopperm commented 1 week ago

We recently rebased on top of https://github.com/llvm/llvm-project/pull/90413, causing many deprecation warnings across CIR's codebase. The use of mlir::Type's member functions should be mechanically replaced by the corresponding free functions.

bcardosolopes commented 1 week ago

We must! I wonder if MLIR folks used clang-tidy or something to fix that. It's also going to be annoying to enforce that during review, but hopefully folks are going to catch up fast.

jopperm commented 1 week ago

I'll look into it!