Closed matthew-f closed 1 month ago
@llvm/issue-subscribers-clang-tidy
Author: None (matthew-f)
Sounds like the issue is its not properly handling inline namespaces
@matthew-f If you wouldn't mind could you test that linked MR. I wasn't able to reproduce the crash with the test cases, but it seems like it should be fixed
Hi @njames93 . That fix does work on my test case. Thank you.
Should this still be backported to 19? in that case someone needs to request a PR.
Yes, it need.
Should this still be backported to 19? in that case someone needs to request a PR.
Can the fix from the linked PR not simply be cherry picked?
In order for the release managers to keep up with the number of fixes that should be merged we want people to follow these instructions - https://llvm.org/docs/GitHub.html#backporting-fixes-to-the-release-branches
/pull-request llvm/llvm-project#101482
The modernize-use-ranges check is crashing. This is the backtrace:
The problem is the 'Qualified name is not found in 'Replaces'. As a hack, this fixes it:
In the instance when it crashed, the 'Qualified' name was
::std::_V2::rotate
. The 'Replaces' map does contain '::std::rotate'I don't know this code at all, and from the assert it looks like this is not expected, so I'm afraid I'm not submitting a proper fix.