search

llvm / llvm-project

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies.
http://llvm.org
Other
27.83k stars 11.46k forks source link

[mlir] Interfaces use the fallback implementation for TypeIDs #100488

Open youngar opened 1 month ago

youngar commented 1 month ago

It seems like interface definitions don't use the MLIR_DECLARE_EXPLICIT_TYPE_ID macro, and so rely on the implicit fallback mechanism to allocate storage for their TypeId. This seems like an oversight to me, and should be easy to fix, although there might be some technical reason for how it works right now.

llvmbot commented 1 month ago

@llvm/issue-subscribers-mlir-core

Author: Andrew Young (youngar)

It seems like interface definitions don't use the `MLIR_DECLARE_EXPLICIT_TYPE_ID` macro, and so rely on the implicit fallback mechanism to allocate storage for their TypeId. This seems like an oversight to me, and should be easy to fix, although there might be some technical reason for how it works right now.