llvm / llvm-project

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies.
http://llvm.org
Other
27.91k stars 11.52k forks source link

[Clang] Suggest more test cases on issue 79748 #102422

Open lyazj opened 1 month ago

lyazj commented 1 month ago

This is just a robustness enhancement suggestion.

https://github.com/llvm/llvm-project/issues/79748

I triggered this issue and found the solution done in https://github.com/llvm/llvm-project/issues/79748. However, the test cases attached to https://github.com/agozillon/llvm-project/commit/323660ae742aecb524898f956590d599e8869f7f do not include those for reference qualifiers, in addition to cv-qualifiers. As for the completeness consideration, I suggest to add more test cases like:

void* operator new(size_t bytes) &;  //expected-error...
void* operator new(size_t bytes) &&;  //expected-error...
llvmbot commented 1 month ago

@llvm/issue-subscribers-clang-frontend

Author: 小小佳的云朵儿~ (lyazj)

This is just a robustness enhancement suggestion. https://github.com/llvm/llvm-project/issues/79748 I triggered this issue and found the solution done in https://github.com/llvm/llvm-project/issues/79748. However, the test cases attached to https://github.com/agozillon/llvm-project/commit/323660ae742aecb524898f956590d599e8869f7f do not include those for reference qualifiers, in addition to cv-qualifiers. As for the completeness consideration, I suggest to add more test cases like: ```c++ void* operator new(size_t bytes) &; //expected-error... void* operator new(size_t bytes) &&; //expected-error... ```
llvmbot commented 1 month ago

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

  1. Check that no other contributor has already been assigned to this issue. If you believe that no one is actually working on it despite an assignment, ping the person. After one week without a response, the assignee may be changed.
  2. In the comments of this issue, request for it to be assigned to you, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
  3. Fix the issue locally.
  4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
  5. Create a Git commit.
  6. Run git clang-format HEAD~1 to format your changes.
  7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

llvmbot commented 1 month ago

@llvm/issue-subscribers-good-first-issue

Author: 小小佳的云朵儿~ (lyazj)

This is just a robustness enhancement suggestion. https://github.com/llvm/llvm-project/issues/79748 I triggered this issue and found the solution done in https://github.com/llvm/llvm-project/issues/79748. However, the test cases attached to https://github.com/agozillon/llvm-project/commit/323660ae742aecb524898f956590d599e8869f7f do not include those for reference qualifiers, in addition to cv-qualifiers. As for the completeness consideration, I suggest to add more test cases like: ```c++ void* operator new(size_t bytes) &; //expected-error... void* operator new(size_t bytes) &&; //expected-error... ```
0xzre commented 1 month ago

Working on this to submit a patch with those additional test cases :)