[clang-tidy] False positive modernize-avoid-c-arrays for function parameters

[chrchr-github]

#include <iostream>

void f(const char a[]) {
    std::cout << a;
}

void g(const char* p) {
    f("abc");
    f(p);
}

<source>:3:14: warning: do not declare C-style arrays, use std::array<> instead [modernize-avoid-c-arrays]
    3 | void f(const char a[]) {
      |              ^

Clearly std::array cannot be used here.

[chrchr-github]

Related: https://github.com/llvm/llvm-project/issues/60411

[HerrCai0907]

I don't think it is a false positive. f should receive a c-str instead of an array of char, though the diagnose message is not correct. You should correct it with const char* instead if array<char, ?>.

[HerrCai0907]

IgnoreStringArrayIfNeededMatcher may help you to ignore this warning.