Open RKSimon opened 1 week ago
Hi!
This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:
test/
create fine-grained testing targets, so you can e.g. use make check-clang-ast
to only run Clang's AST tests.git clang-format HEAD~1
to format your changes.If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.
@llvm/issue-subscribers-good-first-issue
Author: Simon Pilgrim (RKSimon)
Interested to work on it
We already have matchers for ISD::SMAX/SMIN/UMAX/UMIN nodes, but it'd be useful if we could match icmp+select patterns as well, preferably with the same existing m_SMax/m_SMin/m_UMax/m_UMin helpers.
This would be similar to the the IR PatternMatch MaxMin_match helpers which match the min/max intrinsics and the cmp+select patterns.