llvm / llvm-project

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies.
http://llvm.org
Other
28.87k stars 11.93k forks source link

scalbln(x, n), scalbn(x, n), ldexp(x, n) are not folded at the compilation time when (x, n) is constant #112631

Open k-arrows opened 2 weeks ago

k-arrows commented 2 weeks ago

Consider the following example. https://godbolt.org/z/54xsG8WTr

#include <cmath>

double f1() {
  return std::scalbln(3.0, 4);
}

double f2() {
  return std::scalbn(3.0, 4);
}

double f3() {
  return std::ldexp(3.0, 4);
}
llvmbot commented 2 weeks ago

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

  1. Check that no other contributor has already been assigned to this issue. If you believe that no one is actually working on it despite an assignment, ping the person. After one week without a response, the assignee may be changed.
  2. In the comments of this issue, request for it to be assigned to you, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
  3. Fix the issue locally.
  4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
  5. Create a Git commit.
  6. Run git clang-format HEAD~1 to format your changes.
  7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

llvmbot commented 2 weeks ago

@llvm/issue-subscribers-good-first-issue

Author: None (k-arrows)

Consider the following example. https://godbolt.org/z/54xsG8WTr ```cpp #include <cmath> double f1() { return std::scalbln(3.0, 4); } double f2() { return std::scalbn(3.0, 4); } double f3() { return std::ldexp(3.0, 4); } ```
dtcxzyw commented 2 weeks ago

Should first add TLI support for scalbln/scalbn.

arsenm commented 2 weeks ago

llvm.ldexp will be constant folded. Surprisingly these are not resulting in llvm.ldexp, and are using the libcalls

fawdlstty commented 2 weeks ago

I am interested in this issue, please assign it to me. Thank you