llvm / llvm-project

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies.
http://llvm.org
Other
28.8k stars 11.91k forks source link

[libc] wrong header guard on libc/src/__support/big_int.h #114572

Open nickdesaulniers opened 2 hours ago

nickdesaulniers commented 2 hours ago

libc/src/__support/big_int.h has the header guards:

#ifndef LLVM_LIBC_SRC___SUPPORT_UINT_H
#define LLVM_LIBC_SRC___SUPPORT_UINT_H
...
#endif // LLVM_LIBC_SRC___SUPPORT_UINT_H

These 3 should be changed to LLVM_LIBC_SRC___SUPPORT_BIG_INT_H.

llvmbot commented 2 hours ago

@llvm/issue-subscribers-libc

Author: Nick Desaulniers (nickdesaulniers)

libc/src/__support/big_int.h has the header guards: ```c #ifndef LLVM_LIBC_SRC___SUPPORT_UINT_H #define LLVM_LIBC_SRC___SUPPORT_UINT_H ... #endif // LLVM_LIBC_SRC___SUPPORT_UINT_H ``` These 3 should be changed to `LLVM_LIBC_SRC___SUPPORT_BIG_INT_H`.
llvmbot commented 2 hours ago

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

  1. Check that no other contributor has already been assigned to this issue. If you believe that no one is actually working on it despite an assignment, ping the person. After one week without a response, the assignee may be changed.
  2. In the comments of this issue, request for it to be assigned to you, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
  3. Fix the issue locally.
  4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
  5. Create a Git commit.
  6. Run git clang-format HEAD~1 to format your changes.
  7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

llvmbot commented 2 hours ago

@llvm/issue-subscribers-good-first-issue

Author: Nick Desaulniers (nickdesaulniers)

libc/src/__support/big_int.h has the header guards: ```c #ifndef LLVM_LIBC_SRC___SUPPORT_UINT_H #define LLVM_LIBC_SRC___SUPPORT_UINT_H ... #endif // LLVM_LIBC_SRC___SUPPORT_UINT_H ``` These 3 should be changed to `LLVM_LIBC_SRC___SUPPORT_BIG_INT_H`.