search

llvm / llvm-project

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies.
http://llvm.org
Other
29.26k stars 12.08k forks source link

[mlir][CallGraph] Missed visibility for CallGraphNode to construct AbstractEdge #115437

Open Luhaocong opened 2 weeks ago

Luhaocong commented 2 weeks ago

Hi River @River707 @tensorflower-gardener ，In CallGraph Analysis, I find a AbstractEdge will always be added to target CallGraphNode from externalCallerNode, no matter the target is a public or private FunctionOpInterface (which is derived class of CallableOpInterface) .

https://github.com/llvm/llvm-project/blob/c17a914675f8fcadbf0ef440aae7e0ab6c49ec0c/mlir/lib/Analysis/CallGraph.cpp#L125-L131

Is there any plan to add visibility for CallableOpInterface to get better analysis result ？Or could you please give me some advice, I can try to fix this problem?

Luhaocong commented 1 week ago

move to https://github.com/llvm/llvm-project/pull/116177

EugeneZelenko commented 1 week ago

Not merged yet.