search

llvm / llvm-project

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies.
http://llvm.org
Other
29.35k stars 12.14k forks source link

move `AST_MATCHER(VarDecl, isLocal) { return Node.isLocalVarDecl(); }` to ast-matcher #117431

Open HerrCai0907 opened 6 days ago

HerrCai0907 commented 6 days ago

isLocal used in some of tidy's check. I think maybe we can move it to some common part. e.g. ast-matcher or clang-tidy/utils folder.

llvmbot commented 6 days ago

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

  1. Check that no other contributor has already been assigned to this issue. If you believe that no one is actually working on it despite an assignment, ping the person. After one week without a response, the assignee may be changed.
  2. In the comments of this issue, request for it to be assigned to you, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
  3. Fix the issue locally.
  4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
  5. Create a Git commit.
  6. Run git clang-format HEAD~1 to format your changes.
  7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

llvmbot commented 6 days ago

@llvm/issue-subscribers-good-first-issue

Author: Congcong Cai (HerrCai0907)

`isLocal` used in some of tidy's check. I think maybe we can move it to some common part. e.g. ast-matcher or clang-tidy/utils folder.
llvmbot commented 6 days ago

@llvm/issue-subscribers-clang-tidy

Author: Congcong Cai (HerrCai0907)

`isLocal` used in some of tidy's check. I think maybe we can move it to some common part. e.g. ast-matcher or clang-tidy/utils folder.
PiotrZSL commented 6 days ago

Most probably checks could switch to hasLocalStorage, and result would be same.

HerrCai0907 commented 6 days ago

Most probably checks could switch to hasLocalStorage, and result would be same.

isLocal will contains static local.

phychee commented 6 days ago

Hello, could I take up this issue? Thanks!

pdoundka commented 4 days ago

hello, can you assign this to me?

AaronBallman commented 4 days ago

hello, can you assign this to me?

@phychee put up a PR for this already, so I assigned it to them first (sorry).