Clang-3.4 r196771 breaks the build

[llvmbot]

Bugzilla Link	18198
Resolution	FIXED
Resolved on	Dec 10, 2013 13:50
Version	unspecified
OS	Linux
Reporter	LLVM Bugzilla Contributor
CC	@majnemer,@isanbard,@zygoloid

Extended Description

markus@x4 llvm_build % ninja [203/572] Building CXX object tools/clang/lib/AST/CMakeFiles/clangAST.dir/MicrosoftMangle.cpp.o FAILED: /usr/bin/g++ -DCLANG_ENABLE_ARCMT -DCLANG_ENABLE_REWRITER -DCLANG_ENABLE_STATIC_ANALYZER -D_GNU_SOURCE -DSTDC_CONSTANT_MACROS -DSTDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -DclangAST_EXPORTS -fPIC -fvisibility-inlines-hidden -Wall -W -Wno-unused-parameter -Wwrite-strings -Wno-missing-field-initializers -pedantic -Wno-long-long -Wno-maybe-uninitialized -Wnon-virtual-dtor -fno-common -Woverloaded-virtual -Wcast-qual -fno-strict-aliasing -fno-rtti -O3 -DNDEBUG -pipe -fPIC -Itools/clang/lib/AST -I/home/markus/llvm/tools/clang/lib/AST -I/home/markus/llvm/tools/clang/include -Itools/clang/include -Iinclude -I/home/markus/llvm/include -fno-exceptions -MMD -MT tools/clang/lib/AST/CMakeFiles/clangAST.dir/MicrosoftMangle.cpp.o -MF "tools/clang/lib/AST/CMakeFiles/clangAST.dir/MicrosoftMangle.cpp.o.d" -o tools/clang/lib/AST/CMakeFiles/clangAST.dir/MicrosoftMangle.cpp.o -c /home/markus/llvm/tools/clang/lib/AST/MicrosoftMangle.cpp /home/markus/llvm/tools/clang/lib/AST/MicrosoftMangle.cpp: In member function ‘void {anonymous}::MicrosoftCXXNameMangler::mangleNumber(int64_t)’: /home/markus/llvm/tools/clang/lib/AST/MicrosoftMangle.cpp:418:12: error: assignment of read-only location ‘std::reverse_iterator<_Iterator>::operator++(int) with _Iterator = const char*.std::reverse_iterator<_Iterator>::operator<const char>()’ *I++ = 'A' + (Value & 0xf); ^ [203/572] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Function.cpp.o ninja: build stopped: subcommand failed.

[ec04fc15-fa35-46f2-80e1-5d271f2ef708]

Fixed by r196945: merging r196768 to the 3.4 branch.

[llvmbot]

I guess Bill just forgot to merge the LLVM part.

[llvmbot]

BTW I'm not the only one who sees this issue. Look at the mailing list.

[llvmbot]

Because r196771 was merged as r196878.

[991901f3-cc14-4404-b340-165691b62a58]

Clang r196771 requires llvm with changes from r196768, I do not see why you would expect building with the release branch instead of some trunk revision would work.

[llvmbot]

r196886 on release_34 branch.

[991901f3-cc14-4404-b340-165691b62a58]

What revision is your llvm checkout?

[llvmbot]

That change to clang required a change in llvm, please try updating it.

I always update them simultaneously.

[991901f3-cc14-4404-b340-165691b62a58]

That change to clang required a change in llvm, please try updating it.