search

llvm / llvm-project

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies.
http://llvm.org
Other
29.4k stars 12.15k forks source link

[3.9.1 Merge] r279955 Fix pair::operator=(TupleLike&&). #29648

Closed llvmbot closed 8 years ago

llvmbot commented 8 years ago
Bugzilla Link 30300
Resolution INVALID
Resolved on Sep 15, 2016 00:02
Version 3.8
OS Windows NT
Blocks llvm/llvm-project#29609
Reporter LLVM Bugzilla Contributor
CC @mclow

Extended Description

This assignment operator was previously broken since the SFINAE always resulted in substitution failure. This caused assignments to turn into copy construction + assignment.

llvmbot commented 8 years ago

I'm a giant idiot. This bug is not in 3.9 because I only changed pair in 4.0. I forgot that since the corresponding tuple changes are in 3.9.

In summary there is nothing to fix. Sorry for the noise.

llvmbot commented 8 years ago

Assigning to me as is the process. @​Tom may I merge this now?

mclow commented 8 years ago

Yes, I'm fine with this patch.

tstellar commented 8 years ago

Marshall is this OK to merge to the 3.9 branch: https://reviews.llvm.org/rL279955