Open RKSimon opened 7 years ago
mentioned in issue llvm/llvm-project#41767
mentioned in issue llvm/llvm-project#38627
mentioned in issue llvm/llvm-project#38405
mentioned in issue llvm/llvm-project#38404
mentioned in issue llvm/llvm-project#36889
mentioned in issue llvm/llvm-project#36888
mentioned in issue llvm/llvm-project#36469
mentioned in issue llvm/llvm-project#35683
mentioned in issue llvm/llvm-project#35187
mentioned in issue llvm/llvm-project#35149
mentioned in issue llvm/llvm-project#34931
mentioned in issue llvm/llvm-project#34537
mentioned in issue llvm/llvm-project#34422
mentioned in issue llvm/llvm-project#32747
mentioned in issue llvm/llvm-project#32714
mentioned in issue llvm/llvm-project#32512
mentioned in issue llvm/llvm-project#31793
mentioned in issue llvm/llvm-project#31750
mentioned in issue llvm/llvm-project#31696
mentioned in issue llvm/llvm-project#31216
mentioned in issue llvm/llvm-project#31215
mentioned in issue llvm/llvm-project#31140
mentioned in issue llvm/llvm-project#31106
mentioned in issue llvm/llvm-project#31097
mentioned in issue llvm/llvm-project#31046
mentioned in issue llvm/llvm-project#31034
mentioned in issue llvm/llvm-project#31030
mentioned in issue llvm/llvm-project#30961
mentioned in issue llvm/llvm-project#30942
mentioned in issue llvm/llvm-project#30921
mentioned in issue llvm/llvm-project#30902
mentioned in issue llvm/llvm-project#30871
mentioned in issue llvm/llvm-project#30860
mentioned in issue llvm/llvm-project#30859
mentioned in issue llvm/llvm-project#30849
mentioned in issue llvm/llvm-project#30847
mentioned in issue llvm/llvm-project#30839
mentioned in issue llvm/llvm-project#30831
mentioned in issue llvm/llvm-project#30828
mentioned in issue llvm/llvm-project#30820
mentioned in issue llvm/llvm-project#30816
Huh, I got still another fail today on SystemZ with llvm/trunk@292353 cfe/trunk@292343 test-suite/trunk@292129
NewGVN.cpp:1084: void NewGVN::moveValueToNewCongruenceClass(llvm::Instruction, CongruenceClass, CongruenceClass*): Assertion `(!isa
(NewClass->RepLeader) || !NewClass->RepLeader || I == NewClass->RepLeader || !DT->properlyDominates( I->getParent(), cast (NewClass->RepLeader)->getParent())) && "New class for instruction should not be dominated by instruction"' failed. /bin/opt -O3 -enable-newgvn -S ./newgvn_fail.ll
I postedthe reduced test-case above.
Thank you very much. I'll reduce/investigate this. For the future, do you mind to open a new issue and link it here? It would make our tracking much easier =)
Huh, I got still another fail today on SystemZ with llvm/trunk@292353 cfe/trunk@292343 test-suite/trunk@292129
NewGVN.cpp:1084: void NewGVN::moveValueToNewCongruenceClass(llvm::Instruction, CongruenceClass, CongruenceClass*): Assertion `(!isa
/bin/opt -O3 -enable-newgvn -S ./newgvn_fail.ll
I postedthe reduced test-case above.
Ah, great :-)
I tried to apply the attached patch, but it did not apply cleanly anymore, at least not in my repo with latest changes.
Let me know when the test-suite passes on X86, and I will gladly run it on SystemZ.
/Jonas
LLVM passes test-suite on X86 now, so I think we're in a good shape to try on other platforms if you want to take a look.
damn, s/LLVM/LLVM with NewGVN/
Ah, great :-)
I tried to apply the attached patch, but it did not apply cleanly anymore, at least not in my repo with latest changes.
Let me know when the test-suite passes on X86, and I will gladly run it on SystemZ.
/Jonas
LLVM passes test-suite on X86 now, so I think we're in a good shape to try on other platforms if you want to take a look.
Ah, great :-)
I tried to apply the attached patch, but it did not apply cleanly anymore, at least not in my repo with latest changes.
Let me know when the test-suite passes on X86, and I will gladly run it on SystemZ.
/Jonas
Sorry, but I haven't even opened the NewGVN.cpp file. My idea was to contribute by running the test-suite on SystemZ, which I did. I was expecting the author(s) of the code would then take the time to fix any issues.
(and yes, the crash I found is still there as far as I can see)
Sorry, but I haven't even opened the NewGVN.cpp file. My idea was to contribute by running the test-suite on SystemZ, which I did. I was expecting the author(s) of the code would then take the time to fix any issues.
Extended Description
Meta ticket covering the addition of the NewGVN pass.
WIP Patch: https://reviews.llvm.org/D26224