search

llvm / llvm-project

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies.
http://llvm.org
Other
29.11k stars 12.01k forks source link

--autocomplete results contain a typo when completing warning flags #33238

Closed Teemperor closed 7 years ago

Teemperor commented 7 years ago
Bugzilla Link 33891
Resolution FIXED
Resolved on Jul 26, 2017 09:16
Version 5.0
OS All
Blocks llvm/llvm-project#33196
CC @zmodem

Extended Description

Requesting clang to complete a "-Wno-XXX" flag with the help of the --autocomplete flag is returning wrong results in the current clang 5.0 branch.

clang 5.0 is for example completing "-Wno" with "-Wnoeverything" instead of "-Wno-everything" (notice the missing "-" behind the "no"), causing the bash completion to suggest the wrong flag to the user.

This was fixed by Yuka in this commit: https://reviews.llvm.org/rL308824

zmodem commented 7 years ago

Requesting clang to complete a "-Wno-XXX" flag with the help of the --autocomplete flag is returning wrong results in the current clang 5.0 branch.

clang 5.0 is for example completing "-Wno" with "-Wnoeverything" instead of "-Wno-everything" (notice the missing "-" behind the "no"), causing the bash completion to suggest the wrong flag to the user.

This was fixed by Yuka in this commit: https://reviews.llvm.org/rL308824

Merged to 5.0 in r309130. Thanks!