Open llvmbot opened 6 years ago
When the argument -- is passed to clang-tidy-diff.py it should pass the following arguments to clang-tidy. It does that but also includes -- as an argument,
in line 73, https://github.com/llvm-mirror/clang-tools-extra/blob/master/clang-tidy/tool/clang-tidy-diff.py#L73 there should be a +1 in the '--' index.
So only the following arguments as passed to clang-tidy.
It should read: clang_tidy_args.extend(argv[argv.index('--')+1:])
Link to the suggested patch: https://reviews.llvm.org/D49864
I'll be better to suggest patch on https://reviews.llvm.org.
Extended Description
When the argument -- is passed to clang-tidy-diff.py it should pass the following arguments to clang-tidy. It does that but also includes -- as an argument,
in line 73, https://github.com/llvm-mirror/clang-tools-extra/blob/master/clang-tidy/tool/clang-tidy-diff.py#L73 there should be a +1 in the '--' index.
So only the following arguments as passed to clang-tidy.
It should read: clang_tidy_args.extend(argv[argv.index('--')+1:])