llvm / llvm-project

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies.
http://llvm.org
Other
28.87k stars 11.93k forks source link

then-branch and else-branch of the same if-statement should not be the same.(llvm-project/clang/lib/Basic/Targets/ARM.cpp:line 981<-->988) #46419

Open llvmbot opened 4 years ago

llvmbot commented 4 years ago
Bugzilla Link 47075
Version trunk
OS All
Reporter LLVM Bugzilla Contributor
CC @efriedma-quic,@zygoloid,@smithp35

Extended Description

then-branch and else-branch of the same if-statement should not be the same.

commit e3546c78cabfbf670391a57766872f0a8e28a423

llvm-project/clang/lib/Basic/Targets/ARM.cpp:line 981<-->988

979 case 'K': 980 if (isThumb()) { 981 if (!supportsThumb2()) 982 // FIXME: should check if immediate value can be obtained from shifting 983 // a value between 0 and 255 left by any amount 984 Info.setRequiresImmediate(); 985 else 986 // FIXME: should check if immediate value would be valid for a Thumb2 987 // data-processing instruction when inverted 988 Info.setRequiresImmediate(); 989 } else 990 // FIXME: should check if immediate value would be valid for an ARM 991 // data-processing instruction when inverted 992 Info.setRequiresImmediate(); 993 return true;

Reported by: Ustchcs Toolsets Bugfinder (bugfinder-2.1: then-branch and else-branch of the same if-statement should not be the same.)

efriedma-quic commented 2 years ago

mentioned in issue llvm/llvm-bugzilla-archive#47076

efriedma-quic commented 4 years ago

Bug llvm/llvm-bugzilla-archive#47076 has been marked as a duplicate of this bug.