llvm / llvm-project

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies.
http://llvm.org
Other
28.06k stars 11.59k forks source link

Correct vFile:pread/pwrite packet format incompatibility with gdb #47164

Open DavidSpickett opened 3 years ago

DavidSpickett commented 3 years ago
Bugzilla Link 47820
Version 11.0
OS All
CC @JDevlieghere

Extended Description

This is derived from discussion on: https://reviews.llvm.org/D89227

Where I updated the docs to say that vFile:pread/pwrite use different number formats in gdb and lldb.

The protocol specification requires hex formatted numbers (no mention of 0x prefix or not) gdb/gdb-server send/expect to get hex numbers without an 0x prefix lldb/lldb-server send decimal numbers and expect to get either decimal numbers or hex with the 0x prefix

Plan to fix this: (from labath's comment)

Which gets us to matching gdb.

Waiting some time allows us to keep some compatibility going between old clients and new servers. I'm interpreting this to mean wait a release between each one.

DavidSpickett commented 3 years ago

After discussion a soloution involving querying formats in qSupported looks like the better way to go.

See comments on https://reviews.llvm.org/D89227