search

llvm / llvm-project

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies.
http://llvm.org
Other
27.89k stars 11.51k forks source link

Implement AsmParser and Disassembler for M68k #48320

Open glaubitz opened 3 years ago

glaubitz commented 3 years ago
Bugzilla Link 48976
Version trunk
OS Linux
Depends On llvm/llvm-project#49206 llvm/llvm-project#49207 llvm/llvm-project#49208 #53798
Blocks llvm/llvm-project#4440 llvm/llvm-project#48135
CC @glaubitz,@mshockwave,@nickdesaulniers,@ricky26

Extended Description

The M68k backend is still missing the AsmParser and Disassembler, both should be implemented before the backend becomes ready for production.

A draft implementation for both already exists in an external repository [1].

[1] https://github.com/ricky26/M680x0-mono-repo/tree/m68k-assembler

ricky26 commented 2 years ago

mentioned in issue llvm/llvm-project#49207

ricky26 commented 2 years ago

mentioned in issue llvm/llvm-project#49208

ricky26 commented 2 years ago

mentioned in issue llvm/llvm-project#49206

ricky26 commented 3 years ago

Delayed comment but an initial version of the disassembler landed in https://github.com/llvm/llvm-project/commit/2221185776c39aab7b49a141993fa9a0d752a8d5.

mshockwave commented 3 years ago

Update: Initial version of AsmParser has landed. https://github.com/llvm/llvm-project/commit/6e098e133dc7b0fb7006bd768989ef65dfaf341d

ricky26 commented 3 years ago

I've put WIP drafts of the assembler & disassembler from my fork up on phabricator.

Assembler: https://reviews.llvm.org/D98537 Disassembler: https://reviews.llvm.org/D98540

nickdesaulniers commented 3 years ago

The linux kernel will be a great test case for AsmParser. :)

glaubitz commented 2 years ago

I think this can be closed as both the Assembler and Disassembler have been implemented unless I am missing something. @mshockwave @0x59616e

0x59616e commented 2 years ago

I have no idea about the current status of assembler/disassembler since I mostly focused on instruction selector. 🤪

mshockwave commented 2 years ago

I think this can be closed as both the Assembler and Disassembler have been implemented unless I am missing something. @mshockwave @0x59616e

I think this can be closed. Though we probably need a new disassembler since code beads is going away (which the current disassembler is depended on). Let me open a new issue for that.

ricky26 commented 2 years ago

I think this one was still open because there was one sub-ticket which I think we considered essential. :thinking:

mshockwave commented 2 years ago

I think this one was still open because there was one sub-ticket which I think we considered essential. 🤔

You have a point, I forgot there are other issues blocking this.