search

llvm / llvm-project

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies.
http://llvm.org
Other
28.27k stars 11.68k forks source link

Implement more Python DSL-based "exhaustive" sparse kernel generators (easy starter) #51657

Open aartbik opened 2 years ago

aartbik commented 2 years ago
Bugzilla Link 52315
Version unspecified
OS Linux
CC @joker-eph

Extended Description

Currently, we have an interesting "exhaustive" test generator that constructs, runs, and verifies many versions of SpMM (see https://github.com/llvm/llvm-project/blob/main/mlir/test/python/dialects/sparse_tensor/test_SpMM.py) [note that we don't actually exhaustively generate all versions to keep testing time down, but the code can in principle generate and test all versions).

We need more interesting kernels like this to be "exhaustively" tested(or, for practical reasons, pick a good subset of versions). This entry encapsulates adding a number of interesting kernels to this directory using the same style of DSL based testing.

AbrarQuazi commented 1 year ago

Hi I am interested in starting this or any "beginner" level ticket, however I see a "404 page not found" for most of the beginner level tickets. What is the status of these tickets? Do they still need to be done?

aartbik commented 1 year ago

Ah, this is an old tracker. The file has moved since then.

New location: https://github.com/llvm/llvm-project/blob/main/mlir/test/Integration/Dialect/SparseTensor/python/test_SpMM.py

llvmbot commented 1 year ago

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

1) Assign the issue to you. 2) Fix the issue locally. 3) Run the test suite locally. 3.1) Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests. 4) Create a git commit 5) Run git clang-format HEAD~1 to format your changes. 6) Submit the patch to Phabricator. 6.1) Detailed instructions can be found here

For more instructions on how to submit a patch to LLVM, see our documentation.

If you have any further questions about this issue, don't hesitate to ask via a comment on this Github issue.

@llvm/issue-subscribers-good-first-issue

aditya-167 commented 11 months ago

Hi @AbrarQuazi @aartbik are you still working on this? I would like to contribute, I am new to LLVM however, I gone through contirbutors guid and kaleidoscope tutorial, kindly guide me.

AbrarQuazi commented 11 months ago

Hi @aditya-167 I have not gotten the chance yet to start this. I am new to LLVM as well. Would you like to collaborate on this together? If you are in the LLVM discord, you can reach me at @abrar9122

aditya-167 commented 11 months ago

Hi @aditya-167 I have not gotten the chance yet to start this. I am new to LLVM as well. Would you like to collaborate on this together? If you are in the LLVM discord, you can reach me at @abrar9122

Hi @AbrarQuazi, sure would like to collaborate, I have sent you a request in discord.