Open 0x59616e opened 2 years ago
@llvm/issue-subscribers-backend-m68k
Candidate Patch: https://reviews.llvm.org/D126349
@0x59616e - ok to close this?
Not yet. We still have lots of outdated tablegen code.
The lingering codebeads part in M68kInstrFormats.rd
has been removed : 1290d0ddce55bba97d142dd769bbf2364d765e33.
TL;DR
The new disassembler cf0b6df6dbf5 has been commited, it's time to remove code beads.
Details
Code bead is the old encoding mechanism for M68k. Since now we have a new one, it's useless and we need to remove it. I did a quick look through, we may need to modify these files (including but not limited to):
llvm/lib/Target/M68k/CMakeLists.txt
Just remove thetablegen(.... -gen-code-bead)
line.llvm/lib/Target/M68k/M68kInstrFormats.td
I think this one is the biggest one. It has tons of codebead-related code and comments.llvm/lib/Target/M68k/M68kInstrInfo.cpp
llvm/lib/Target/M68k/MCTargetDesc/M68kMCCodeEmitter.cpp
These two has some codebead-related code. Not a big problemllvm/utils/TableGen/CMakeLists.txt
llvm/utils/TableGen/CodeBeadsGen.cpp
Delete this onellvm/utils/TableGen/TableGen.cpp
Remove the switch case.