Open gnawme opened 2 years ago
@llvm/issue-subscribers-clang-tidy
clang-tidy
also flags this destructor with the message:
/__w/pcl/pcl/visualization/include/pcl/visualization/common/actor_map.h:72:17: error: use '= default' to define a trivial destructor [modernize-use-equals-default,-warnings-as-errors]
virtual ~CloudActor ()
even though the destructor has a body.
On further reflection, clang-tidy
is likely not suggesting that I do this:
StopWatch () : start_time_ (std::chrono::steady_clock::now()) = default;
but that this is equivalent (including initializing start_time_
to ::now()
):
StopWatch () = default;
which is likely not the case.
Linting the file with clang-tidy (trunk), the constructor isn't marked. Can you confirm the issue is fixed, @gnawme?
When running
run-clang-tidy-14
on the Point Cloud Library,clang-tidy
flags this constructor with the message:Setup from Github Action clang-tidy.yml: