Open kuhar opened 1 year ago
@llvm/issue-subscribers-mlir-spirv
Hi!
This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:
test/
create fine-grained testing targets, so you can e.g. use make check-clang-ast
to only run Clang's AST tests.git clang-format HEAD~1
to format your changes.If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.
@llvm/issue-subscribers-good-first-issue
Author: Jakub Kuderski (kuhar)
Update: I looked at this at some point and this would require writing a bunch of custom parsing/printing code similar to the llvm dialect. There was a proposal presented during the US LLVM Dev / MLIR summit to allow these abbreviated formats in a more general way. I can't find the abstract now, maybe someone like @ftynse or @jpienaar know what I'm talking about.
I think we should put this issue on hold until this generic support in MLIR is in place.
We can elide the leading dialect prefix when dealing with nested SPIR-V types, e.g.:
!spirv.ptr<!spirv.array<...>>
==>!spirv.ptr<array<...>>
.The abbreviated format should support arbitrary nesting of SPIR-V types.